[llvm-commits] [PATCH] remove redundant 'static'
Zhongxing Xu
xuzhongxing at gmail.com
Mon Mar 8 18:59:31 PST 2010
2010/3/9 Chris Lattner <clattner at apple.com>:
>
> On Mar 8, 2010, at 5:05 PM, Zhongxing Xu wrote:
>
>> 2010/3/9 Chris Lattner <clattner at apple.com>:
>>>
>>> On Mar 8, 2010, at 4:45 AM, Zhongxing Xu wrote:
>>>
>>>> 'static' is redundant in this context:
>>>
>>> Um, no it's not. It prevents exporting the symbol from the .o file. What are you trying to fix?
>>>
>>
>> 'const' in namespace scope implies internal linkage. Is that
>> sufficient to prevent exporting the symbol from the .o file?
>
> It could be, but why do this? What does it fix? IMO, static is a lot less subtle.
I think it makes the code more concise. But never mind. It does not
fix anything real.
More information about the llvm-commits
mailing list