[llvm-commits] [llvm] r98015 - in /llvm/trunk/lib/CodeGen/AsmPrinter: DwarfDebug.cpp DwarfPrinter.cpp DwarfPrinter.h

Chris Lattner sabre at nondot.org
Mon Mar 8 16:26:09 PST 2010


Author: lattner
Date: Mon Mar  8 18:26:09 2010
New Revision: 98015

URL: http://llvm.org/viewvc/llvm-project?rev=98015&view=rev
Log:
mc'ize the last use of PrintLabelName and eliminate PrintLabelName.

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfPrinter.cpp
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfPrinter.h

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=98015&r1=98014&r2=98015&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Mon Mar  8 18:26:09 2010
@@ -15,6 +15,7 @@
 #include "llvm/Module.h"
 #include "llvm/CodeGen/MachineFunction.h"
 #include "llvm/CodeGen/MachineModuleInfo.h"
+#include "llvm/MC/MCExpr.h"
 #include "llvm/MC/MCSection.h"
 #include "llvm/MC/MCStreamer.h"
 #include "llvm/MC/MCAsmInfo.h"
@@ -2967,12 +2968,11 @@
       DIE *SP = LI->second;
       Asm->EmitInt32(SP->getOffset()); EOL("DIE offset");
 
-      if (TD->getPointerSize() == sizeof(int32_t))
-        O << MAI->getData32bitsDirective();
-      else
-        O << MAI->getData64bitsDirective();
-
-      PrintLabelName(getDWLabel("label", LI->first)); EOL("low_pc");
+      // FIXME: "Labels" should hold MCSymbol*'s
+      MCSymbol *L = getDWLabel("label", LI->first);
+      if (Asm->VerboseAsm) Asm->OutStreamer.AddComment("low_pc");
+      Asm->OutStreamer.EmitValue(MCSymbolRefExpr::Create(L, Asm->OutContext),
+                                 TD->getPointerSize(), 0/*AddrSpace*/);
     }
   }
 

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfPrinter.cpp?rev=98015&r1=98014&r2=98015&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfPrinter.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfPrinter.cpp Mon Mar  8 18:26:09 2010
@@ -209,13 +209,6 @@
 }
 
 
-/// PrintLabelName - Print label name in form used by Dwarf writer.
-///
-void DwarfPrinter::PrintLabelName(const MCSymbol *Label) const {
-  // FIXME: REMOVE.
-  O << Label->getName();
-}
-
 /// EmitReference - Emit a reference to a label.
 ///
 void DwarfPrinter::EmitReference(const MCSymbol *Sym, bool IsPCRelative,
@@ -229,7 +222,7 @@
   const TargetLoweringObjectFile &TLOF = Asm->getObjFileLowering();
 
   PrintRelDirective(Encoding);
-  O << *TLOF.getSymbolForDwarfReference(Sym, Asm->MMI, Encoding);;
+  O << *TLOF.getSymbolForDwarfReference(Sym, Asm->MMI, Encoding);
 }
 
 void DwarfPrinter::EmitReference(const GlobalValue *GV, unsigned Encoding)const{
@@ -300,8 +293,6 @@
       EmitCFAByte(dwarf::DW_CFA_advance_loc4);
       EmitDifference(getDWLabel("label", LabelID),
                      getDWLabel(BaseLabel, BaseLabelID), true);
-      Asm->O << '\n';
-
       BaseLabelID = LabelID;
       BaseLabel = "label";
       IsLocal = true;

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfPrinter.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfPrinter.h?rev=98015&r1=98014&r2=98015&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfPrinter.h (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfPrinter.h Mon Mar  8 18:26:09 2010
@@ -113,10 +113,6 @@
                    unsigned PadTo = 0) const;
 
   
-  /// PrintLabelName - Print label name in form used by Dwarf writer.
-  ///
-  void PrintLabelName(const MCSymbol *Label) const;
-
   /// EmitReference - Emit a reference to a label.
   ///
   void EmitReference(const MCSymbol *Label, bool IsPCRelative = false,





More information about the llvm-commits mailing list