[llvm-commits] [llvm] r97667 - in /llvm/trunk: include/llvm/CodeGen/MachineInstr.h lib/CodeGen/MachineCSE.cpp

[Evan Cheng]

On Mar 3, 2010, at 2:21 PM, Jakob Stoklund Olesen wrote:

> 
> On Mar 3, 2010, at 1:47 PM, Evan Cheng wrote:
> 
>> Author: evancheng
>> Date: Wed Mar  3 15:47:16 2010
>> New Revision: 97667
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=97667&view=rev
>> Log:
>> Move DenseMapInfo for MachineInstr* to MachineInstr.h
> 
> Are you sure it is a good idea to change the semantics of all our DenseMap<MachineInstr*,...>? There is a lot of them around.

I clearly wasn't thinking. What do you expect!? :-)

> 
> I think it would be better to implement a Traits class that can be used explicitly when you need your MachineInstrs compared by value instead of by pointer.
> 
> Also, please replace PHIElimination::PHINodeTraits with whatever you end up with. It serves the same purpose.

Yep.

Evan

> 
> /jakob
>