[llvm-commits] [llvm] r97515 - /llvm/trunk/utils/TableGen/DAGISelMatcherGen.cpp

[Chris Lattner]

Author: lattner
Date: Mon Mar  1 16:49:06 2010
New Revision: 97515

URL: http://llvm.org/viewvc/llvm-project?rev=97515&view=rev
Log:
resolve some fixmes

Modified:
    llvm/trunk/utils/TableGen/DAGISelMatcherGen.cpp

Modified: llvm/trunk/utils/TableGen/DAGISelMatcherGen.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/DAGISelMatcherGen.cpp?rev=97515&r1=97514&r2=97515&view=diff
==============================================================================
--- llvm/trunk/utils/TableGen/DAGISelMatcherGen.cpp (original)
+++ llvm/trunk/utils/TableGen/DAGISelMatcherGen.cpp Mon Mar  1 16:49:06 2010
@@ -36,12 +36,9 @@
       VT = RC.getValueTypeNum(0);
       continue;
     }
-    
-    // In multiple RC's.  If the Types of the RC's do not agree, return
-    // MVT::Other. The target is responsible for handling this.
-    if (VT != RC.getValueTypeNum(0))
-      // FIXME2: when does this happen?  Abort?
-      return MVT::Other;
+
+    // If this occurs in multiple register classes, they all have to agree.
+    assert(VT == RC.getValueTypeNum(0));
   }
   return VT;
 }
@@ -849,10 +846,6 @@
     AddMatcher(new MarkFlagResultsMatcher(MatchedFlagResultNodes.data(),
                                           MatchedFlagResultNodes.size()));
   
-  
-  // We know that the resulting pattern has exactly one result/
-  // FIXME2: why?  what about something like (set a,b,c, (complexpat))
-  // FIXME2: Implicit results should be pushed here I guess?
   AddMatcher(new CompleteMatchMatcher(Ops.data(), Ops.size(), Pattern));
 }