[llvm-commits] [llvm] r97417 - in /llvm/trunk: include/llvm/CodeGen/DAGISelHeader.h lib/CodeGen/SelectionDAG/SelectionDAG.cpp

[Chris Lattner]

Author: lattner
Date: Sun Feb 28 15:36:14 2010
New Revision: 97417

URL: http://llvm.org/viewvc/llvm-project?rev=97417&view=rev
Log:
enhance the new isel to handle the 'node already exists'
case of MorphNodeTo directly.

Modified:
    llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

Modified: llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h?rev=97417&r1=97416&r2=97417&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h (original)
+++ llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h Sun Feb 28 15:36:14 2010
@@ -842,7 +842,19 @@
       
       // Create the node.
       SDNode *Res = 0;
-      if (Opcode == OPC_MorphNodeTo) {
+      if (Opcode != OPC_MorphNodeTo) {
+        // If this is a normal EmitNode command, just create the new node and
+        // add the results to the RecordedNodes list.
+        Res = CurDAG->getMachineNode(TargetOpc, NodeToMatch->getDebugLoc(),
+                                     VTList, Ops.data(), Ops.size());
+        
+        // Add all the non-flag/non-chain results to the RecordedNodes list.
+        for (unsigned i = 0, e = VTs.size(); i != e; ++i) {
+          if (VTs[i] == MVT::Other || VTs[i] == MVT::Flag) break;
+          RecordedNodes.push_back(SDValue(Res, i));
+        }
+        
+      } else {
         // It is possible we're using MorphNodeTo to replace a node with no
         // normal results with one that has a normal result (or we could be
         // adding a chain) and the input could have flags and chains as well.
@@ -862,9 +874,15 @@
         
         Res = CurDAG->MorphNodeTo(NodeToMatch, ~TargetOpc, VTList,
                                   Ops.data(), Ops.size());
-        // Reset the node ID, to the isel, this should be just like a newly
-        // allocated machine node.
-        Res->setNodeId(-1);
+        
+        // MorphNodeTo can operate in two ways: if an existing node with the
+        // specified operands exists, it can just return it.  Otherwise, it
+        // updates the node in place to have the requested operands.
+        if (Res == NodeToMatch) {
+          // If we updated the node in place, reset the node ID.  To the isel,
+          // this should be just like a newly allocated machine node.
+          Res->setNodeId(-1);
+        }
         
         // FIXME: Whether the selected node has a flag result should come from
         // flags on the node.
@@ -873,7 +891,7 @@
           // Move the flag if needed.
           if (OldFlagResultNo != -1 &&
               (unsigned)OldFlagResultNo != ResNumResults-1)
-            ReplaceUses(SDValue(Res, OldFlagResultNo), 
+            ReplaceUses(SDValue(NodeToMatch, OldFlagResultNo), 
                         SDValue(Res, ResNumResults-1));
           --ResNumResults;
         }
@@ -881,16 +899,12 @@
         // Move the chain reference if needed.
         if ((EmitNodeInfo & OPFL_Chain) && OldChainResultNo != -1 &&
             (unsigned)OldChainResultNo != ResNumResults-1)
-          ReplaceUses(SDValue(Res, OldChainResultNo), 
+          ReplaceUses(SDValue(NodeToMatch, OldChainResultNo), 
                       SDValue(Res, ResNumResults-1));
-      } else {
-        Res = CurDAG->getMachineNode(TargetOpc, NodeToMatch->getDebugLoc(),
-                                     VTList, Ops.data(), Ops.size());
-      
-        // Add all the non-flag/non-chain results to the RecordedNodes list.
-        for (unsigned i = 0, e = VTs.size(); i != e; ++i) {
-          if (VTs[i] == MVT::Other || VTs[i] == MVT::Flag) break;
-          RecordedNodes.push_back(SDValue(Res, i));
+
+        if (Res != NodeToMatch) {
+          // Otherwise, no replacement happened because the node already exists.
+          ReplaceUses(NodeToMatch, Res);
         }
       }
       
@@ -926,7 +940,7 @@
         // Update chain and flag uses.
         UpdateChainsAndFlags(NodeToMatch, InputChain, ChainNodesMatched,
                              InputFlag, FlagResultNodesMatched, true);
-        return Res;
+        return 0;
       }
       
       continue;

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp?rev=97417&r1=97416&r2=97417&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp Sun Feb 28 15:36:14 2010
@@ -4660,7 +4660,7 @@
   return MorphNodeTo(N, Opc, VTs, Ops, 3);
 }
 
-/// MorphNodeTo - These *mutate* the specified node to have the specified
+/// MorphNodeTo - This *mutates* the specified node to have the specified
 /// return type, opcode, and operands.
 ///
 /// Note that MorphNodeTo returns the resultant node.  If there is already a