[llvm-commits] [llvm] r97132 - in /llvm/trunk/lib/Bitcode: Reader/BitcodeReader.cpp Writer/ValueEnumerator.cpp

[Nick Lewycky]

I just want to clarify that you'll need to rebuild your llvm-gcc/clang 
because of this, or else 'make check' will fail for you.

Nick

Nick Lewycky wrote:
> Author: nicholas
> Date: Thu Feb 25 02:30:17 2010
> New Revision: 97132
>
> URL: http://llvm.org/viewvc/llvm-project?rev=97132&view=rev
> Log:
> Make the side-numbering of instructions used by metadata (which is needed to
> keep track of instructions that return void) per-function. This fixes PR5278.
>
> This breaks backwards compatibility with the metadata format. That's okay
> because we haven't released the metadata bitcode yet.
>
> Modified:
>      llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
>      llvm/trunk/lib/Bitcode/Writer/ValueEnumerator.cpp
>
> Modified: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp?rev=97132&r1=97131&r2=97132&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp (original)
> +++ llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp Thu Feb 25 02:30:17 2010
> @@ -1622,6 +1622,7 @@
>     if (Stream.EnterSubBlock(bitc::FUNCTION_BLOCK_ID))
>       return Error("Malformed block record");
>
> +  InstructionList.clear();
>     unsigned ModuleValueListSize = ValueList.size();
>
>     // Add all the function arguments to the value table.
>
> Modified: llvm/trunk/lib/Bitcode/Writer/ValueEnumerator.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Writer/ValueEnumerator.cpp?rev=97132&r1=97131&r2=97132&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Bitcode/Writer/ValueEnumerator.cpp (original)
> +++ llvm/trunk/lib/Bitcode/Writer/ValueEnumerator.cpp Thu Feb 25 02:30:17 2010
> @@ -39,8 +39,6 @@
>
>   /// ValueEnumerator - Enumerate module-level information.
>   ValueEnumerator::ValueEnumerator(const Module *M) {
> -  InstructionCount = 0;
> -
>     // Enumerate the global variables.
>     for (Module::const_global_iterator I = M->global_begin(),
>            E = M->global_end(); I != E; ++I)
> @@ -377,6 +375,7 @@
>
>
>   void ValueEnumerator::incorporateFunction(const Function&F) {
> +  InstructionCount = 0;
>     NumModuleValues = Values.size();
>
>     // Adding function arguments to the value table.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>