[llvm-commits] [llvm] r97081 - /llvm/trunk/utils/TableGen/DAGISelMatcherGen.cpp

[Chris Lattner]

Author: lattner
Date: Wed Feb 24 18:03:03 2010
New Revision: 97081

URL: http://llvm.org/viewvc/llvm-project?rev=97081&view=rev
Log:
add a fixme for an experiment that defeated me for the time being.

Modified:
    llvm/trunk/utils/TableGen/DAGISelMatcherGen.cpp

Modified: llvm/trunk/utils/TableGen/DAGISelMatcherGen.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/DAGISelMatcherGen.cpp?rev=97081&r1=97080&r2=97081&view=diff
==============================================================================
--- llvm/trunk/utils/TableGen/DAGISelMatcherGen.cpp (original)
+++ llvm/trunk/utils/TableGen/DAGISelMatcherGen.cpp Wed Feb 24 18:03:03 2010
@@ -490,6 +490,10 @@
 void MatcherGen::EmitMatcherCode() {
   // If the pattern has a predicate on it (e.g. only enabled when a subtarget
   // feature is around, do the check).
+  // FIXME: This should get emitted after the match code below to encourage
+  // sharing.  This can't happen until we get an X86ISD::AddrMode node made by
+  // dag combine, eliminating the horrible side-effect-full stuff from 
+  // X86's MatchAddress.
   if (!Pattern.getPredicateCheck().empty())
     AddMatcherNode(new 
                  CheckPatternPredicateMatcherNode(Pattern.getPredicateCheck()));