[llvm-commits] [llvm] r96990 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Evan Cheng evan.cheng at apple.com
Tue Feb 23 13:51:54 PST 2010


Author: evancheng
Date: Tue Feb 23 15:51:54 2010
New Revision: 96990

URL: http://llvm.org/viewvc/llvm-project?rev=96990&view=rev
Log:
Fix rev 96389 by restricting the xform to mask that's either signbit or max signed value.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=96990&r1=96989&r2=96990&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Tue Feb 23 15:51:54 2010
@@ -9092,9 +9092,10 @@
 }
 
 /// PerformANDCombine - Look for SSE and instructions of this form:
-/// (and x, (build_vector c1,c2,c3,c4)). If there exists a use of a build_vector
-/// that's the bitwise complement of the mask, then transform the node to
-/// (and (xor x, (build_vector -1,-1,-1,-1)), (build_vector ~c1,~c2,~c3,~c4)).
+/// (and x, (build_vector signbit,signbit,signbit,signbit)). If there
+/// exists a use of a build_vector that's the bitwise complement of the mask,
+/// then transform the node to
+/// (and (xor x, (build_vector -1,-1,-1,-1)), (build_vector ~sb,~sb,~sb,~sb)).
 static SDValue PerformANDCombine(SDNode *N, SelectionDAG &DAG,
                                  TargetLowering::DAGCombinerInfo &DCI) {
   EVT VT = N->getValueType(0);
@@ -9118,7 +9119,11 @@
         continue;
       }
       ConstantSDNode *C = dyn_cast<ConstantSDNode>(Arg);
-      if (!C) return SDValue();
+      if (!C)
+        return SDValue();
+      if (!C->getAPIntValue().isSignBit() &&
+          !C->getAPIntValue().isMaxSignedValue())
+        return SDValue();
       Mask.push_back(DAG.getConstant(~C->getAPIntValue(), EltVT));
     }
     N1 = DAG.getNode(ISD::BUILD_VECTOR, N1.getDebugLoc(), VT,





More information about the llvm-commits mailing list