[llvm-commits] [PATCH] Support the 'alignstack' attribute in the x86 backend

[Anton Korobeynikov]

Hello, Charles

> This patch in the force_align_arg_pointer series adds support for the
> alignstack() attribute to the x86 backend. It's a very simple patch, but
> I feel like it's missing something.
Yes, a bit. Two questions:
1. What if current stack alignment is more than specified by
attribute. In such case no realignment will be needed. However, I feel
that in such case your patch will force realignment as well. Try to
increase the stack alignment and / or just try the stuff with darwin.
2. Are you sure that the maximum alignment you set won't be clobberred
in the case when e.g. there will be vector spills?

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University