[llvm-commits] [llvm-gcc-4.2] r96467 - /llvm-gcc-4.2/trunk/gcc/varasm.c

Eric Christopher echristo at apple.com
Tue Feb 16 23:44:58 PST 2010


Author: echristo
Date: Wed Feb 17 01:44:58 2010
New Revision: 96467

URL: http://llvm.org/viewvc/llvm-project?rev=96467&view=rev
Log:
Revert for now:

r95604 | dpatel | 2010-02-08 15:26:53 -0800 (Mon, 08 Feb 2010) | 3 lines

Emit debug info for unused name space global variable. This will be
easily optimized by the optimizer in -O1+ mode.
This is done by forcing DECL_LLVM() check earlier, which in turn creates
llvm symbol for the decl.

It was causing issues with self hosting in non-optimized mode.

Modified:
    llvm-gcc-4.2/trunk/gcc/varasm.c

Modified: llvm-gcc-4.2/trunk/gcc/varasm.c
URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/varasm.c?rev=96467&r1=96466&r2=96467&view=diff

==============================================================================
--- llvm-gcc-4.2/trunk/gcc/varasm.c (original)
+++ llvm-gcc-4.2/trunk/gcc/varasm.c Wed Feb 17 01:44:58 2010
@@ -1361,15 +1361,7 @@
 {
   const char **type = &first_global_object_name;
 
-  /* LLVM LOCAL begin */
-  if (
-#ifndef ENABLE_LLVM
-    !MEM_P (DECL_RTL (decl))
-#else
-    (DECL_LLVM (decl), 0)
-#endif
-    || first_global_object_name
-    /* LLVM LOCAL end */
+  if (first_global_object_name
       || !TREE_PUBLIC (decl)
       || DECL_EXTERNAL (decl)
       || !DECL_NAME (decl)
@@ -1377,7 +1369,15 @@
 	  && (TREE_CODE (decl) != VAR_DECL
 	      || (DECL_COMMON (decl)
 		  && (DECL_INITIAL (decl) == 0
-		      || DECL_INITIAL (decl) == error_mark_node)))))
+		      || DECL_INITIAL (decl) == error_mark_node))))
+      /* LLVM LOCAL begin */
+#ifndef ENABLE_LLVM
+      || !MEM_P (DECL_RTL (decl))
+#else
+      || (DECL_LLVM (decl), 0)
+#endif
+      )
+    /* LLVM LOCAL end */
     return;
 
   /* We win when global object is found, but it is useful to know about weak





More information about the llvm-commits mailing list