[llvm-commits] [llvm] r96188 - /llvm/trunk/utils/TableGen/DAGISelEmitter.cpp

Chris Lattner sabre at nondot.org
Sun Feb 14 13:11:53 PST 2010


Author: lattner
Date: Sun Feb 14 15:11:53 2010
New Revision: 96188

URL: http://llvm.org/viewvc/llvm-project?rev=96188&view=rev
Log:
remove the DisablePatternForFastISel predicate, which is a check
that predated -fast-isel which attempted to speed up the dag pattern
matchers at -O0.  Since fast-isel is around, this is basically 
obsolete and removing it shrinks the generated dag isels.

Modified:
    llvm/trunk/utils/TableGen/DAGISelEmitter.cpp

Modified: llvm/trunk/utils/TableGen/DAGISelEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/DAGISelEmitter.cpp?rev=96188&r1=96187&r2=96188&view=diff

==============================================================================
--- llvm/trunk/utils/TableGen/DAGISelEmitter.cpp (original)
+++ llvm/trunk/utils/TableGen/DAGISelEmitter.cpp Sun Feb 14 15:11:53 2010
@@ -261,24 +261,6 @@
   return CGP.getSDNodeInfo(Op).getEnumName();
 }
 
-static
-bool DisablePatternForFastISel(TreePatternNode *N, CodeGenDAGPatterns &CGP) {
-  bool isStore = !N->isLeaf() &&
-    getOpcodeName(N->getOperator(), CGP) == "ISD::STORE";
-  if (!isStore && NodeHasProperty(N, SDNPHasChain, CGP))
-    return false;
-
-  bool HasChain = false;
-  for (unsigned i = 0, e = N->getNumChildren(); i != e; ++i) {
-    TreePatternNode *Child = N->getChild(i);
-    if (PatternHasProperty(Child, SDNPHasChain, CGP)) {
-      HasChain = true;
-      break;
-    }
-  }
-  return HasChain;
-}
-
 //===----------------------------------------------------------------------===//
 // Node Transformation emitter implementation.
 //
@@ -594,10 +576,6 @@
   if (isRoot) {
     // Record input varargs info.
     NumInputRootOps = N->getNumChildren();
-    
-    if (DisablePatternForFastISel(N, CGP))
-      emitCheck("OptLevel != CodeGenOpt::None");
-    
     emitCheck(PredicateCheck);
   }
   
@@ -1506,7 +1484,8 @@
   bool FoundChain = false;
   Emitter.EmitMatchCode(Pattern.getSrcPattern(), NULL, "N", "", FoundChain);
 
-  // TP - Get *SOME* tree pattern, we don't care which.
+  // TP - Get *SOME* tree pattern, we don't care which.  It is only used for
+  // diagnostics, which we know are impossible at this point.
   TreePattern &TP = *CGP.pf_begin()->second;
   
   // At this point, we know that we structurally match the pattern, but the
@@ -1699,7 +1678,7 @@
   for (CodeGenDAGPatterns::ptm_iterator I = CGP.ptm_begin(),
        E = CGP.ptm_end(); I != E; ++I) {
     const PatternToMatch &Pattern = *I;
-
+    
     TreePatternNode *Node = Pattern.getSrcPattern();
     if (!Node->isLeaf()) {
       PatternsByOpcode[getOpcodeName(Node->getOperator(), CGP)].





More information about the llvm-commits mailing list