[llvm-commits] [llvm] r95656 - in /llvm/trunk/test/CodeGen: Generic/ X86/

[Chris Lattner]

On Feb 8, 2010, at 11:49 PM, Anton Korobeynikov wrote:

> Hi, Chris
>
>>    llvm/trunk/test/CodeGen/Generic/2007-04-14-BitTestsBadMask.ll
>>    llvm/trunk/test/CodeGen/Generic/2007-04-27-BitTestsBadMask.ll
> Why have you removed these two ones? They test actual regressions!

The former is huge and unreduced.  The later didn't seem very important.

>>
>> -; RUN: grep jb %t | count 1
>> -; RUN: grep \\\$6 %t | count 2
>> -; RUN: grep 1024 %t | count 1
>> -; RUN: grep 1023 %t | count 1
>> -; RUN: grep 119  %t | count 1
>> -; RUN: grep JTI %t | count 2
>> -; RUN: grep jg %t | count 3
>> -; RUN: grep ja %t | count 1
>> -; RUN: grep jns %t | count 1
> These files actually test the behaviour of switch lowering. You just
> removed that. Surely, it will never crash.


We have several other tests for switch lowering.  Why is this one  
important?  Are you worried about switch lowering miscompiling a  
switch?  How is that any more likely than switch lowering crashing?

-Chris