[llvm-commits] [llvm] r95527 - /llvm/trunk/lib/VMCore/TypesContext.h

Nick Lewycky nicholas at mxc.ca
Sun Feb 7 13:13:47 PST 2010


Author: nicholas
Date: Sun Feb  7 15:13:46 2010
New Revision: 95527

URL: http://llvm.org/viewvc/llvm-project?rev=95527&view=rev
Log:
Make the destructor for TypeMapBase protected. Spotted by Duncan Sands with
cppcheck!

Modified:
    llvm/trunk/lib/VMCore/TypesContext.h

Modified: llvm/trunk/lib/VMCore/TypesContext.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/TypesContext.h?rev=95527&r1=95526&r2=95527&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/TypesContext.h (original)
+++ llvm/trunk/lib/VMCore/TypesContext.h Sun Feb  7 15:13:46 2010
@@ -216,7 +216,6 @@
   ///
   std::multimap<unsigned, PATypeHolder> TypesByHash;
 
-public:
   ~TypeMapBase() {
     // PATypeHolder won't destroy non-abstract types.
     // We can't destroy them by simply iterating, because
@@ -236,6 +235,7 @@
     }
   }
 
+public:
   void RemoveFromTypesByHash(unsigned Hash, const Type *Ty) {
     std::multimap<unsigned, PATypeHolder>::iterator I =
       TypesByHash.lower_bound(Hash);
@@ -281,7 +281,6 @@
   std::map<ValType, PATypeHolder> Map;
 public:
   typedef typename std::map<ValType, PATypeHolder>::iterator iterator;
-  ~TypeMap() { print("ON EXIT"); }
 
   inline TypeClass *get(const ValType &V) {
     iterator I = Map.find(V);





More information about the llvm-commits mailing list