[llvm-commits] [llvm] r95333 - /llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp

[Bob Wilson]

OK.  I added one in revision 95465.

On Feb 5, 2010, at 12:12 AM, Duncan Sands wrote:

> Hi Bob,
> 
>> Do not reassociate expressions with i1 type.  SimplifyCFG converts some
>> short-circuited conditions to AND/OR expressions, and those expressions
>> are often converted back to a short-circuited form in code gen.  The
>> original source order may have been optimized to take advantage of the
>> expected values, and if we reassociate them, we change the order and
>> subvert that optimization.  Radar 7497329.
> 
> a testcase would be nice.
> 
> Ciao,
> 
> Duncan.