[llvm-commits] [llvm] r95336 - in /llvm/trunk: lib/CodeGen/AsmPrinter/AsmPrinter.cpp test/CodeGen/PowerPC/2010-02-04-EmptyGlobal.ll

[Bill Wendling]

On Feb 4, 2010, at 5:10 PM, Chris Lattner wrote:

> On Feb 4, 2010, at 4:17 PM, Bill Wendling wrote:
> 
>> Author: void
>> Date: Thu Feb  4 18:17:02 2010
>> New Revision: 95336
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=95336&view=rev
>> Log:
>> An empty global constant (one of size 0) may have a section immediately
>> following it. However, the EmitGlobalConstant method wasn't emitting a body for
>> the constant. The assembler doesn't like that. Before, we were generating this:
>> 
>> .zerofill __DATA, __common, __cmd, 1, 3
>> 
>> This fix puts us back to that semantic.
> 
> The patch looks good.  Please change the testcase to just contain the zero sized zero fill global and FileCheck for the .byte 0 after the label.
> 
Done. Thanks! :)

-bw