[llvm-commits] [llvm-gcc][patch] Don't use inreg to force arguments to memory :-)

Rafael Espindola espindola at google.com
Wed Feb 3 21:26:31 PST 2010


> llvm-gcc compiled fine and I am running the test-suite. I will commit
> it if everything is fine.

New patch attached. The test-suite found an issue: llvm-gcc was
emitting the pad for integer argument after the real argument. This
would missalign the following arguments. Fixed by moving the padding
to before the argument.

This patch also has one additional modification in llvm-convert.cpp.
The function prolog visitor was avoiding calling
ABIConverter.HandleArgument for byval argument. For the ppc backend
this is a problem since the NumGPR would not be updated and the casts
would be incorrect. For the default ABI this change is a nop. It
really looks like this was an issue before, it is just that adding the
pads causes a different set of failures.

llvm-gcc compiled. Running the llvm test-suite again. If everything is
fine tomorrow I will run it on x86_64 and if everything is fine again
I will commit it.

Cheers,
-- 
Rafael Ávila de Espíndola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: inreg.patch
Type: text/x-diff
Size: 7525 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100204/b6d03257/attachment.patch>


More information about the llvm-commits mailing list