[llvm-commits] [llvm] r94974 - in /llvm/trunk/tools/ed: EDDisassembler.cpp EDDisassembler.h EDInst.cpp EDInst.h EDMain.cpp EDOperand.cpp EDOperand.h EDToken.cpp EDToken.h EnhancedDisassembly.exports

[Sean Callanan]

Sounds good to me!  If I don't hear any complaints by tomorrow morning, I'll rename the subdirectory to edis.

Sean

On Feb 1, 2010, at 4:29 PM, Bob Wilson wrote:

> You could compromise and go with something like "edis"
> 
> On Feb 1, 2010, at 4:24 PM, Sean Callanan wrote:
> 
>> Dan,
>> 
>> you're right, and I definitely wouldn't name an executable that way.
>> 
>> The library that's built in tools/ed is libEnhancedDisassembler.a/.so.  The reason I called the directory ed is that if I called it EnhancedDisassembly it would play havoc with what people see when they type 'ls' in the tools subdirectory, and it would be annoying to cd into that directory.
>> 
>> If you think the potential confusion still outweighs the benefits of a compact folder name, let me know and I'll see what I can do to fix it.
>> 
>> Sean
>> 
>> 
>> On Feb 1, 2010, at 12:23 PM, Dan Gohman wrote:
>> 
>>> Hi Sean,
>>> 
>>> "ed" is the name of a standard utility program in POSIX, SUS, etc.
>>> 
>>> Dan
>>> 
>>> On Feb 1, 2010, at 12:49 AM, Sean Callanan wrote:
>>> 
>>>> Author: spyffe
>>>> Date: Mon Feb  1 02:49:35 2010
>>>> New Revision: 94974
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=94974&view=rev
>>>> Log:
>>>> Added the enhanced disassembly library's implementation and
>>>> fleshed out the .exports file.  I still have to fix several
>>>> details of operand parsing, but the basic functionality is
>>>> there and usable.
>>>> 
>>>> Added:
>>>> llvm/trunk/tools/ed/EDDisassembler.cpp
>>>> llvm/trunk/tools/ed/EDDisassembler.h
>>>> llvm/trunk/tools/ed/EDInst.cpp
>>>> llvm/trunk/tools/ed/EDInst.h
>>>> llvm/trunk/tools/ed/EDOperand.cpp
>>>> llvm/trunk/tools/ed/EDOperand.h
>>>> llvm/trunk/tools/ed/EDToken.cpp
>>>> llvm/trunk/tools/ed/EDToken.h
>>>> Modified:
>>>> llvm/trunk/tools/ed/EDMain.cpp
>>>> llvm/trunk/tools/ed/EnhancedDisassembly.exports
>>>> 
>>>> Added: llvm/trunk/tools/ed/EDDisassembler.cpp
>>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>