[llvm-commits] [llvm] r94457 - /llvm/trunk/lib/Target/ARM/AsmPrinter/ARMInstPrinter.cpp

[Johnny Chen]

Since there is no ARM/Thumb disassembler in the repository, the test case is going to fail.
Should I just back out the change and keep it in my local workspace?

Thanks.

On Jan 25, 2010, at 3:17 PM, Chris Lattner wrote:

> 
> On Jan 25, 2010, at 2:13 PM, Johnny Chen wrote:
> 
>> Author: johnny
>> Date: Mon Jan 25 16:13:10 2010
>> New Revision: 94457
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=94457&view=rev
>> Log:
>> Implemented ARMInstPrinter::printThumbS4ImmOperand().
> 
> Hi Johnny, testcase please!
> 
> -Chris
> 
>> 
>> Modified:
>>   llvm/trunk/lib/Target/ARM/AsmPrinter/ARMInstPrinter.cpp
>> 
>> Modified: llvm/trunk/lib/Target/ARM/AsmPrinter/ARMInstPrinter.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/AsmPrinter/ARMInstPrinter.cpp?rev=94457&r1=94456&r2=94457&view=diff
>> 
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> ======================================================================
>> --- llvm/trunk/lib/Target/ARM/AsmPrinter/ARMInstPrinter.cpp (original)
>> +++ llvm/trunk/lib/Target/ARM/AsmPrinter/ARMInstPrinter.cpp Mon Jan 25 16:13:10 2010
>> @@ -353,6 +353,5 @@
>> }
>> 
>> void ARMInstPrinter::printThumbS4ImmOperand(const MCInst *MI, unsigned OpNum) {
>> -  // FIXME: remove this.
>> -  abort();
>> +  O << "#" <<  MI->getOperand(OpNum).getImm() * 4;
>> }
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>