[llvm-commits] [llvm] r94400 - in /llvm/trunk: lib/Target/ARM/ARMMCAsmInfo.cpp test/CodeGen/ARM/align.ll test/CodeGen/ARM/globals.ll

[Rafael Espindola]

> This is almost certainly a bug:
>
> ARMMCAsmInfoDarwin::ARMMCAsmInfoDarwin() {
> ...
>  COMMDirectiveTakesAlignment = false;
>
> Jim, can you see if the darwin assembler accepts _bar with this line removed?  If so, please remove it.

btw, if there is any target that doesn't we are not producing alignment for it:

  if (ByteAlignment != 0 && MAI.getCOMMDirectiveTakesAlignment()) {
    if (MAI.getAlignmentIsInBytes())
      OS << ',' << ByteAlignment;
    else
      OS << ',' << Log2_32(ByteAlignment);
  }

The else is missing :-)

> -Chris

Cheers,
-- 
Rafael Ávila de Espíndola