[llvm-commits] [llvm] r94291 - in /llvm/trunk: lib/Target/X86/X86ISelLowering.cpp test/CodeGen/X86/splat-scalar-load.ll

[Eric Christopher]

Author: echristo
Date: Sat Jan 23 00:02:43 2010
New Revision: 94291

URL: http://llvm.org/viewvc/llvm-project?rev=94291&view=rev
Log:
Don't lower splat vector load to relative to the esp if the
stack may be misaligned.

Update test accordingly.

Patch by Evan Cheng!

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
    llvm/trunk/test/CodeGen/X86/splat-scalar-load.ll

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=94291&r1=94290&r2=94291&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Sat Jan 23 00:02:43 2010
@@ -3390,17 +3390,10 @@
     MachineFrameInfo *MFI = DAG.getMachineFunction().getFrameInfo();
     if (DAG.InferPtrAlignment(Ptr) < 16) {
       if (MFI->isFixedObjectIndex(FI)) {
-        // Can't change the alignment. Reference stack + offset explicitly
-        // if stack pointer is at least 16-byte aligned.
-        unsigned StackAlign = Subtarget->getStackAlignment();
-        if (StackAlign < 16)
-          return SDValue();
-        Offset = MFI->getObjectOffset(FI) + Offset;
-        SDValue StackPtr = DAG.getCopyFromReg(Chain, dl, X86StackPtr,
-                                              getPointerTy());
-        Ptr = DAG.getNode(ISD::ADD, dl, getPointerTy(), StackPtr,
-                          DAG.getConstant(Offset & ~15, getPointerTy()));
-        Offset %= 16;
+        // Can't change the alignment. FIXME: It's possible to compute
+        // the exact stack offset and reference FI + adjust offset instead.
+        // If someone *really* cares about this. That's the way to implement it.
+        return SDValue();
       } else {
         MFI->setObjectAlignment(FI, 16);
       }

Modified: llvm/trunk/test/CodeGen/X86/splat-scalar-load.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/splat-scalar-load.ll?rev=94291&r1=94290&r2=94291&view=diff

==============================================================================
--- llvm/trunk/test/CodeGen/X86/splat-scalar-load.ll (original)
+++ llvm/trunk/test/CodeGen/X86/splat-scalar-load.ll Sat Jan 23 00:02:43 2010
@@ -1,21 +1,6 @@
 ; RUN: llc < %s -mtriple=i386-apple-darwin -mattr=+sse2 | FileCheck %s
 ; rdar://7434544
 
-define <2 x i64> @t1() nounwind ssp {
-entry:
-; CHECK: t1:
-; CHECK: pshufd	$0, (%esp), %xmm0
-  %array = alloca [8 x float], align 16
-  %arrayidx = getelementptr inbounds [8 x float]* %array, i32 0, i32 0
-  %tmp2 = load float* %arrayidx
-  %vecinit = insertelement <4 x float> undef, float %tmp2, i32 0
-  %vecinit5 = insertelement <4 x float> %vecinit, float %tmp2, i32 1
-  %vecinit7 = insertelement <4 x float> %vecinit5, float %tmp2, i32 2
-  %vecinit9 = insertelement <4 x float> %vecinit7, float %tmp2, i32 3
-  %0 = bitcast <4 x float> %vecinit9 to <2 x i64>
-  ret <2 x i64> %0
-}
-
 define <2 x i64> @t2() nounwind ssp {
 entry:
 ; CHECK: t2:
@@ -30,14 +15,3 @@
   %0 = bitcast <4 x float> %vecinit9 to <2 x i64>
   ret <2 x i64> %0
 }
-
-define <4 x float> @t3(float %tmp1, float %tmp2, float %tmp3) nounwind readnone ssp {
-entry:
-; CHECK: t3:
-; CHECK: pshufd	$-86, (%esp), %xmm0
-  %0 = insertelement <4 x float> undef, float %tmp3, i32 0
-  %1 = insertelement <4 x float> %0, float %tmp3, i32 1
-  %2 = insertelement <4 x float> %1, float %tmp3, i32 2
-  %3 = insertelement <4 x float> %2, float %tmp3, i32 3
-  ret <4 x float> %3
-}