[llvm-commits] PR6059 patch

Rafael Espindola espindola at google.com
Fri Jan 22 17:17:46 PST 2010


> It seems like we already have too many different hooks for passing aggregates, and I'm not convinced this is necessary.

And I think the reason for that is that none of them is generic
enough. Just passing the ABIClient should be sufficient to implement
anything that the backend needs. A good cleanup would be to remove the
other hooks.

> Actually, now that I think about it, you should be able to pass the struct from pr6059 as a pair of i64 values, and the backend should be responsible for inserting the padding.  If it doesn't then there is a separate bug in the backend.

I really don't think so. We know in the FE what the alignment will be
and that the argument will be split. Doing this exposes the individual
32 bit units to the IL and reduces the requirements on the backend.

Cheers,
-- 
Rafael Ávila de Espíndola




More information about the llvm-commits mailing list