[llvm-commits] PR6059 patch

Rafael Espindola espindola at google.com
Thu Jan 21 09:42:15 PST 2010


Attached is a potential fix for PR6059. One way to look at it is that
it is a partial revert of Bob's previous patch to fix PR5406. Before
that patch llvm-gcc would use i64 and that would force the arguments
to be correctly aligned. What this patch does is check if it is OK to
use i64. If it is not, we produce an i32 padding.

I have done a quick testing with this patch and

SingleSource/UnitTests/2003-05-07-VarArgs
SingleSource/UnitTests/2003-08-11-VaListArg

are fixed on AAPCS.

Bob, I will do a full test on AAPCS (with qemu). I can test on linux
x86-64 too, but I don't think this code path is used in there. Can you
help me test this? Is there another test I can make with qemu?

Cheers,
-- 
Rafael Ávila de Espíndola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr6059.patch
Type: text/x-diff
Size: 2956 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100121/bccd792f/attachment.patch>


More information about the llvm-commits mailing list