[llvm-commits] [llvm] r93923 - in /llvm/trunk: include/llvm/MC/MCStreamer.h lib/MC/MCAsmStreamer.cpp lib/MC/MCStreamer.cpp

[Chris Lattner]

On Jan 20, 2010, at 3:41 PM, Jim Grosbach wrote:

> Hi Chris,
>
> Should these be adding the newline?

Yes.

> There's various bits that like to emit comments following the data  
> directive on the same line using the AsmPrinter::EOL methods. Having  
> the newline come out here results in an extra newline and the  
> comment being on the following line from the directive.
>
> For example, from the DwarfException::EmitExceptionTable() bits  
> around DwarfException.cpp:857 or so.
>      .byte   3                                           @ Call site  
> format (udata4)
> becomes
>      .byte   3
>                                                                @  
> Call site format (udata4)
>
> It appears there's some mis-match in usage, though, as other places  
> are assuming these emit the newline. CodeGen/PowerPC/i128-and- 
> beyond.ll fails if it's removed, for example.
>
> Purely a cosmetic thing, so not a huge deal, but it caught my eye,  
> so figured I'd mention it.

I completely agree with you.  I'm not sure of a good solution to it,  
but I'm aware of the problem.

-Chris