[llvm-commits] [llvm] r93811 - in /llvm/trunk: lib/CodeGen/SelectionDAG/FastISel.cpp lib/Target/X86/X86FastISel.cpp test/DebugInfo/2010-01-18-DbgValue.ll

[Dale Johannesen]

On Jan 18, 2010, at 3:59 PMPST, Evan Cheng wrote:
>>>> Author: johannes
>>>> Date: Mon Jan 18 17:34:55 2010
>>>> New Revision: 93811
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=93811&view=rev
>>>> Log:
>>>> Enable code to emit dbg.declare as DEBUG_VALUE
>>>> comments (fast isel, X86).  This doesn't seem
>>>> to break any functionality, but will introduce
>>>> cases where -g affects the generated code.  I'll
>>>> be fixing that.
>>>
>>> Ok. But is it safe to enable this now? Or should this wait until  
>>> you have fixed all the places where codegen is affected?
>>>
>>> Evan
>>
>> I don't mind backing it out if you think that's right.  It seems to  
>> me it will get more exposure if I put it in now; it shouldn't break  
>> anything functionally, as I said.
>
> We really shouldn't have -g affect codegen at any time.

7216659 has been ignored for months.

> So yes I'd prefer to disable this but only if llvm-gcc -O0 -g would  
> generate dbg.declare. Would it?

Yes.  All right, I'll back it out and maintain this as a local patch  
in my tree.