[llvm-commits] [llvm] r93753 - in /llvm/trunk: include/llvm/Target/TargetMachine.h lib/CodeGen/AsmPrinter/DwarfException.cpp lib/Target/X86/X86TargetMachine.cpp

[Bill Wendling]

On Jan 18, 2010, at 2:23 PM, Chris Lattner wrote:

> 
> On Jan 18, 2010, at 11:36 AM, Bill Wendling wrote:
> 
>> Author: void
>> Date: Mon Jan 18 13:36:27 2010
>> New Revision: 93753
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=93753&view=rev
>> Log:
>> - Add a comment to the callback indicating that it's *extremely* not  
>> a good
>> idea, but unfortunately necessary.
>> - Default to using 4-bytes for the LSDA pointer encoding to agree  
>> with the
>> encoded value in the CIE.
> 
> Hi Bill,
> 
> Your commit message is much more useful and descriptive than the  
> comment you added.  Please add a descriptive comment that is self  
> contained which explains the issue and what is required to fix it.
> 
Hi Chris,

Okay. I went ahead and improved the comments.

-bw