[llvm-commits] [llvm] r93753 - in /llvm/trunk: include/llvm/Target/TargetMachine.h lib/CodeGen/AsmPrinter/DwarfException.cpp lib/Target/X86/X86TargetMachine.cpp

Bill Wendling isanbard at gmail.com
Mon Jan 18 11:47:57 PST 2010


Done. :)

-bw

On Jan 18, 2010, at 11:40 AM, Eric Christopher wrote:

> 
> On Jan 18, 2010, at 11:36 AM, Bill Wendling wrote:
> 
>> +  /// FIXME: This call-back isn't good! We should be using the correct encoding
>> +  /// regardless of the system. However, there are some systems which have bugs
>> +  /// that prevent this from occuring.
>>  virtual DwarfLSDAEncoding::Encoding getLSDAEncoding() const {
>>    return DwarfLSDAEncoding::Default;
>>  }
>> 
>> 
> 
> Can you add one of these...
> 
>> 
>> DwarfLSDAEncoding::Encoding X86TargetMachine::getLSDAEncoding() const {
>> -  if (Subtarget.isTargetDarwin() && Subtarget.getDarwinVers() > 10)
>> +  if (Subtarget.isTargetDarwin() && Subtarget.getDarwinVers() != 10)
> 
> here too?
> 
> -eric
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list