[llvm-commits] [llvm] r93631 - /llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

[Chris Lattner]

On Jan 15, 2010, at 10:17 PM, Devang Patel wrote:

> Author: dpatel
> Date: Sat Jan 16 00:17:40 2010
> New Revision: 93631
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=93631&view=rev
> Log:
> 
> No need to use WeakVH here.

BTW, if you're worried about the pointer moving, it would be very reasonable to use AssertingVH.

-Chris

> 
> Modified:
>    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
> 
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=93631&r1=93630&r2=93631&view=diff
> 
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Sat Jan 16 00:17:40 2010
> @@ -165,8 +165,7 @@
> class DbgScope {
>   DbgScope *Parent;                   // Parent to this scope.
>   DIDescriptor Desc;                  // Debug info descriptor for scope.
> -  // FIXME : Use of WeakVH may be expensive here.
> -  WeakVH InlinedAtLocation;           // Location at which scope is inlined.
> +  MDNode * InlinedAtLocation;           // Location at which scope is inlined.
>   bool AbstractScope;                 // Abstract Scope
>   unsigned StartLabelID;              // Label ID of the beginning of scope.
>   unsigned EndLabelID;                // Label ID of the end of scope.
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits