[llvm-commits] [llvm] r93587 - in /llvm/trunk: include/llvm/CodeGen/AsmPrinter.h lib/CodeGen/AsmPrinter/AsmPrinter.cpp lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp

[Chris Lattner]

Author: lattner
Date: Fri Jan 15 17:38:51 2010
New Revision: 93587

URL: http://llvm.org/viewvc/llvm-project?rev=93587&view=rev
Log:
add a version of AsmPrinter::printVisibility that takes an MCSymbol.

Modified:
    llvm/trunk/include/llvm/CodeGen/AsmPrinter.h
    llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp

Modified: llvm/trunk/include/llvm/CodeGen/AsmPrinter.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/AsmPrinter.h?rev=93587&r1=93586&r2=93587&view=diff

==============================================================================
--- llvm/trunk/include/llvm/CodeGen/AsmPrinter.h (original)
+++ llvm/trunk/include/llvm/CodeGen/AsmPrinter.h Fri Jan 15 17:38:51 2010
@@ -418,6 +418,9 @@
 
     /// printVisibility - This prints visibility information about symbol, if
     /// this is suported by the target.
+    void printVisibility(const MCSymbol *Sym, unsigned Visibility) const;
+    
+    // FIXME: This is deprecated and should be removed.
     void printVisibility(const std::string& Name, unsigned Visibility) const;
 
     /// printOffset - This is just convenient handler for printing offsets.

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=93587&r1=93586&r2=93587&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Fri Jan 15 17:38:51 2010
@@ -1856,6 +1856,23 @@
   }
 }
 
+void AsmPrinter::printVisibility(const MCSymbol *Sym,
+                                 unsigned Visibility) const {
+  if (Visibility == GlobalValue::HiddenVisibility) {
+    if (const char *Directive = MAI->getHiddenDirective()) {
+      O << Directive;
+      Sym->print(O, MAI);
+      O << '\n';
+    }
+  } else if (Visibility == GlobalValue::ProtectedVisibility) {
+    if (const char *Directive = MAI->getProtectedDirective()) {
+      O << Directive;
+      Sym->print(O, MAI);
+      O << '\n';
+    }
+  }
+}
+
 void AsmPrinter::printOffset(int64_t Offset) const {
   if (Offset > 0)
     O << '+' << Offset;

Modified: llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp?rev=93587&r1=93586&r2=93587&view=diff

==============================================================================
--- llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp Fri Jan 15 17:38:51 2010
@@ -49,7 +49,6 @@
 #include "llvm/Support/CommandLine.h"
 #include "llvm/Support/ErrorHandling.h"
 #include "llvm/Support/FormattedStream.h"
-#include "llvm/Support/Mangler.h"
 #include "llvm/Support/MathExtras.h"
 #include <cctype>
 using namespace llvm;
@@ -1186,9 +1185,7 @@
     return;
   }
 
-  std::string Name = Mang->getMangledName(GVar);
   MCSymbol *GVarSym = GetGlobalValueSymbol(GVar);
-
   
   Constant *C = GVar->getInitializer();
   const Type *Type = C->getType();
@@ -1196,7 +1193,7 @@
   unsigned Align = TD->getPreferredAlignmentLog(GVar);
   bool isDarwin = Subtarget->isTargetDarwin();
 
-  printVisibility(Name, GVar->getVisibility());
+  printVisibility(GVarSym, GVar->getVisibility());
 
   if (Subtarget->isTargetELF()) {
     O << "\t.type ";