[llvm-commits] [llvm] r93580 - /llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp

Dale Johannesen dalej at apple.com
Fri Jan 15 15:29:29 PST 2010


Author: johannes
Date: Fri Jan 15 17:29:29 2010
New Revision: 93580

URL: http://llvm.org/viewvc/llvm-project?rev=93580&view=rev
Log:
Adjust some comments per review.


Modified:
    llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp

Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp?rev=93580&r1=93579&r2=93580&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp (original)
+++ llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp Fri Jan 15 17:29:29 2010
@@ -422,11 +422,13 @@
     printLabel(MI);
     return;
   case TargetInstrInfo::DEBUG_VALUE: {
+    // FIXME: if this is implemented for another target before it goes
+    // away completely, the common part should be moved into AsmPrinter.
     if (!VerboseAsm)
       return;
     O << '\t' << MAI->getCommentString() << "DEBUG_VALUE: ";
     unsigned NOps = MI->getNumOperands();
-    // cast away const; DIetc do not take const operands for some reason
+    // cast away const; DIetc do not take const operands for some reason.
     DIVariable V((MDNode*)(MI->getOperand(NOps-1).getMetadata()));
     O << V.getName();
     O << " <- ";
@@ -435,7 +437,7 @@
       assert(MI->getOperand(0).getType()==MachineOperand::MO_Register);
       printOperand(MI, 0);
     } else {
-      // Frame address.  Currently handles ESP or ESP + offset only
+      // Frame address.  Currently handles register +- offset only.
       assert(MI->getOperand(0).getType()==MachineOperand::MO_Register);
       assert(MI->getOperand(3).getType()==MachineOperand::MO_Immediate);
       O << '['; printOperand(MI, 0); O << '+'; printOperand(MI, 3); O << ']';





More information about the llvm-commits mailing list