[llvm-commits] [llvm] r93247 - in /llvm/trunk: include/llvm/Metadata.h include/llvm/Module.h include/llvm/ValueSymbolTable.h lib/VMCore/Metadata.cpp lib/VMCore/Module.cpp

Chris Lattner clattner at apple.com
Fri Jan 15 13:55:24 PST 2010


On Jan 12, 2010, at 10:34 AM, Devang Patel wrote:
> Author: dpatel
> Date: Tue Jan 12 12:34:06 2010
> New Revision: 93247
>
> URL: http://llvm.org/viewvc/llvm-project?rev=93247&view=rev
> Log:
> Use ilist_tratis to autoinsert and remove NamedMDNode from  
> MDSymbolTable.

Great,

> +++ llvm/trunk/include/llvm/ValueSymbolTable.h Tue Jan 12 12:34:06  
> 2010
> @@ -17,6 +17,7 @@
> #include "llvm/Value.h"
> #include "llvm/ADT/StringMap.h"
> #include "llvm/System/DataTypes.h"
> +#include "llvm/ADT/ilist_node.h"

You shouldn't need this #include.

> +++ llvm/trunk/lib/VMCore/Metadata.cpp Tue Jan 12 12:34:06 2010
>
> /// setName - Set the name of this named metadata.
> void NamedMDNode::setName(StringRef N) {
> +  assert (!N.empty() && "Invalid named metadata name!");
> +  Name = N.str();
> +  if (Parent)
> +    Parent->getMDSymbolTable().insert(N, this);
> }

Doesn't this need to remove the old name from the symbol table before  
setting the new name?

-Chris



More information about the llvm-commits mailing list