[llvm-commits] [llvm] r93369 - in /llvm/trunk: lib/Transforms/InstCombine/InstCombineAddSub.cpp test/Transforms/InstCombine/fsub-fadd.ll

[Chris Lattner]

On Jan 13, 2010, at 3:23 PM, Bill Wendling wrote:

> Author: void
> Date: Wed Jan 13 17:23:17 2010
> New Revision: 93369
>
> URL: http://llvm.org/viewvc/llvm-project?rev=93369&view=rev
> Log:
> When the visitSub method was split into visitSub and visitFSub, this  
> xform was
> added to the FSub version. However, the original version of this  
> xform guarded
> against doing this for floating point (!Op0->getType()- 
> >isFPOrFPVector()).
>
> This is causing LLVM to perform incorrect xforms for code like:

Hi Bill,

The patch is fine, but please reduce the testcase to the minimum  
needed to repro the issue ("X-(X+Y) == -Y") and add it to an  
existing .ll file.

-Chris