[llvm-commits] [llvm] r93504 - in /llvm/trunk: include/llvm/Analysis/DebugInfo.h include/llvm/IntrinsicInst.h include/llvm/Intrinsics.td lib/Analysis/DebugInfo.cpp lib/CodeGen/SelectionDAG/FastISel.cpp lib/VMCore/Verifier.cpp test/Assembler/funct

[Victor Hernandez]

On Jan 15, 2010, at 9:45 AM, Devang Patel wrote:

> On Fri, Jan 15, 2010 at 9:12 AM, Chris Lattner <clattner at apple.com> wrote:
>> 
>> On Jan 14, 2010, at 7:37 PM, Victor Hernandez wrote:
>> 
>>> Author: hernande
>>> Date: Thu Jan 14 21:37:48 2010
>>> New Revision: 93504
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=93504&view=rev
>>> Log:
>>> Improve llvm.dbg.declare intrinsic by referring directly to the
>>> storage in its first argument, via function-local metadata (instead
>>> of via a bitcast).
>>> This patch also cleans up code that expects there to be a bitcast in
>>> the first argument and testcases that call llvm.dbg.declare.
>> 
>> Hi Victor,
>> 
>> This is a IR incompatibility, and this intrinsic existed in LLVM 2.6
>> and earlier.  Please add "autoupgrade" support to the .ll and .bc
>> readers.
>> 
> 
> Chris,
> 
> 2.6 uses GVs for debug info. The autoupgrade support already discards
> dbg intrinsics that do not use use metadata.

No, it only discards llvm.dbg.declare instrinsics whose second argument is not metadata.  My patch affects the first argument.  I'll be updating autoupgrade to fix the first argument of llvm.dbg.declare instrinsics, not just discard the intrinsic.

> 
> -
> Devang