[llvm-commits] [llvm] r93498 - in /llvm/trunk: include/llvm/Target/Target.td include/llvm/Target/TargetInstrInfo.h utils/TableGen/CodeEmitterGen.cpp utils/TableGen/CodeGenTarget.cpp utils/TableGen/InstrInfoEmitter.cpp

Dale Johannesen dalej at apple.com
Thu Jan 14 17:50:45 PST 2010


Author: johannes
Date: Thu Jan 14 19:50:44 2010
New Revision: 93498

URL: http://llvm.org/viewvc/llvm-project?rev=93498&view=rev
Log:
Remove DEBUG_DECLARE, looks like we don't need it.
Also, DEBUG_VALUE has side effects.


Modified:
    llvm/trunk/include/llvm/Target/Target.td
    llvm/trunk/include/llvm/Target/TargetInstrInfo.h
    llvm/trunk/utils/TableGen/CodeEmitterGen.cpp
    llvm/trunk/utils/TableGen/CodeGenTarget.cpp
    llvm/trunk/utils/TableGen/InstrInfoEmitter.cpp

Modified: llvm/trunk/include/llvm/Target/Target.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/Target.td?rev=93498&r1=93497&r2=93498&view=diff

==============================================================================
--- llvm/trunk/include/llvm/Target/Target.td (original)
+++ llvm/trunk/include/llvm/Target/Target.td Thu Jan 14 19:50:44 2010
@@ -482,15 +482,6 @@
   let InOperandList = (ops unknown:$value, i64imm:$offset, unknown:$meta);
   let AsmString = "DEBUG_VALUE";
   let Namespace = "TargetInstrInfo";
-  let neverHasSideEffects = 1;
-  let isAsCheapAsAMove = 1;
-}
-def DEBUG_DECLARE : Instruction {
-  let OutOperandList = (ops);
-  let InOperandList = (ops unknown:$vbl, unknown:$meta);
-  let AsmString = "DEBUG_DECLARE";
-  let Namespace = "TargetInstrInfo";
-  let neverHasSideEffects = 1;
   let isAsCheapAsAMove = 1;
 }
 }

Modified: llvm/trunk/include/llvm/Target/TargetInstrInfo.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetInstrInfo.h?rev=93498&r1=93497&r2=93498&view=diff

==============================================================================
--- llvm/trunk/include/llvm/Target/TargetInstrInfo.h (original)
+++ llvm/trunk/include/llvm/Target/TargetInstrInfo.h Thu Jan 14 19:50:44 2010
@@ -91,10 +91,7 @@
     COPY_TO_REGCLASS = 10,
 
     // DEBUG_VALUE - a mapping of the llvm.dbg.value intrinsic
-    DEBUG_VALUE = 11,
-
-    // DEBUG_DECLARE - a mapping of the llvm.dbg.declare intrinsic
-    DEBUG_DECLARE = 12
+    DEBUG_VALUE = 11
   };
 
   unsigned getNumOpcodes() const { return NumOpcodes; }

Modified: llvm/trunk/utils/TableGen/CodeEmitterGen.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/CodeEmitterGen.cpp?rev=93498&r1=93497&r2=93498&view=diff

==============================================================================
--- llvm/trunk/utils/TableGen/CodeEmitterGen.cpp (original)
+++ llvm/trunk/utils/TableGen/CodeEmitterGen.cpp Thu Jan 14 19:50:44 2010
@@ -35,8 +35,7 @@
         R->getName() == "IMPLICIT_DEF" ||
         R->getName() == "SUBREG_TO_REG" ||
         R->getName() == "COPY_TO_REGCLASS" ||
-        R->getName() == "DEBUG_VALUE" ||
-        R->getName() == "DEBUG_DECLARE") continue;
+        R->getName() == "DEBUG_VALUE") continue;
 
     BitsInit *BI = R->getValueAsBitsInit("Inst");
 
@@ -114,8 +113,7 @@
         R->getName() == "IMPLICIT_DEF" ||
         R->getName() == "SUBREG_TO_REG" ||
         R->getName() == "COPY_TO_REGCLASS" ||
-        R->getName() == "DEBUG_VALUE" ||
-        R->getName() == "DEBUG_DECLARE") {
+        R->getName() == "DEBUG_VALUE") {
       o << "    0U,\n";
       continue;
     }
@@ -154,8 +152,7 @@
         InstName == "IMPLICIT_DEF" ||
         InstName == "SUBREG_TO_REG" ||
         InstName == "COPY_TO_REGCLASS" ||
-        InstName == "DEBUG_VALUE" ||
-        InstName == "DEBUG_DECLARE") continue;
+        InstName == "DEBUG_VALUE") continue;
 
     BitsInit *BI = R->getValueAsBitsInit("Inst");
     const std::vector<RecordVal> &Vals = R->getValues();

Modified: llvm/trunk/utils/TableGen/CodeGenTarget.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/CodeGenTarget.cpp?rev=93498&r1=93497&r2=93498&view=diff

==============================================================================
--- llvm/trunk/utils/TableGen/CodeGenTarget.cpp (original)
+++ llvm/trunk/utils/TableGen/CodeGenTarget.cpp Thu Jan 14 19:50:44 2010
@@ -342,11 +342,6 @@
     throw "Could not find 'DEBUG_VALUE' instruction!";
   const CodeGenInstruction *DEBUG_VALUE = &I->second;
 
-  I = getInstructions().find("DEBUG_DECLARE");
-  if (I == Instructions.end())
-    throw "Could not find 'DEBUG_DECLARE' instruction!";
-  const CodeGenInstruction *DEBUG_DECLARE = &I->second;
-
   // Print out the rest of the instructions now.
   NumberedInstructions.push_back(PHI);
   NumberedInstructions.push_back(INLINEASM);
@@ -360,7 +355,6 @@
   NumberedInstructions.push_back(SUBREG_TO_REG);
   NumberedInstructions.push_back(COPY_TO_REGCLASS);
   NumberedInstructions.push_back(DEBUG_VALUE);
-  NumberedInstructions.push_back(DEBUG_DECLARE);
   for (inst_iterator II = inst_begin(), E = inst_end(); II != E; ++II)
     if (&II->second != PHI &&
         &II->second != INLINEASM &&
@@ -373,8 +367,7 @@
         &II->second != IMPLICIT_DEF &&
         &II->second != SUBREG_TO_REG &&
         &II->second != COPY_TO_REGCLASS &&
-        &II->second != DEBUG_VALUE &&
-        &II->second != DEBUG_DECLARE)
+        &II->second != DEBUG_VALUE)
       NumberedInstructions.push_back(&II->second);
 }
 

Modified: llvm/trunk/utils/TableGen/InstrInfoEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/InstrInfoEmitter.cpp?rev=93498&r1=93497&r2=93498&view=diff

==============================================================================
--- llvm/trunk/utils/TableGen/InstrInfoEmitter.cpp (original)
+++ llvm/trunk/utils/TableGen/InstrInfoEmitter.cpp Thu Jan 14 19:50:44 2010
@@ -346,8 +346,7 @@
         R->getName() != "IMPLICIT_DEF" &&
         R->getName() != "SUBREG_TO_REG" &&
         R->getName() != "COPY_TO_REGCLASS" &&
-        R->getName() != "DEBUG_VALUE" &&
-        R->getName() != "DEBUG_DECLARE")
+        R->getName() != "DEBUG_VALUE")
       throw R->getName() + " doesn't have a field named '" + 
             Val->getValue() + "'!";
     return;





More information about the llvm-commits mailing list