[llvm-commits] [llvm-gcc-4.2] r93409 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

[Duncan Sands]

Hi Evan,

> Add missing memory barrier after binary atomic builtin. r74403 apparently left this out by mistake. x86 target will optimize it away but it's looking for the barrier after the operation.

what do you mean by "it's looking for the barrier after the operation"?

> +#if defined(TARGET_ARM) && defined(CONFIG_DARWIN_H)

Should this really be conditioned on the OS (darwin)?  After all, how
barriers work should be a processor issue, not an OS one...

Ciao,

Duncan.