[llvm-commits] [patch] Add support for emulators in RunSafely.sh

[Nick Lewycky]

On 13 January 2010 15:18, Rafael Espindola <espindola at google.com> wrote:

> 2010/1/13 Nick Lewycky <nlewycky at google.com>:
> > This could be used for a valgrind as well, for example. Maybe the flag
> > should be named "run_under" instead of emulator? I'm on the fence on that
> > because valgrind really is an emulator under the hood.
>
> It could be something else, so it is a good point.
>

Looks good to me. Thanks Rafael!

Nick


>  > This isn't compatible GET_STABLE_NUMBERS, nor remote execution. Instead
> of
> > modifying just one RUNSAFELY line to add $(EMULATOR_OPT), you should put:
> >
> >   ifdef EMULATOR
> >     RUNSAFELY := $(RUNSAFELY) $(EMULATOR_OPT)
> >   endif
> >
> > at line 109.
>
> Updated patch attached. I am testing it.
>
> > Nick
>
> Cheers,
> --
> Rafael Ávila de Espíndola
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100113/8ea07ac0/attachment.html>