[llvm-commits] [llvm] r93305 - in /llvm/trunk/lib/Target: PowerPC/AsmPrinter/PPCAsmPrinter.cpp TargetLoweringObjectFile.cpp X86/AsmPrinter/X86AsmPrinter.cpp

[Chris Lattner]

Author: lattner
Date: Wed Jan 13 01:56:59 2010
New Revision: 93305

URL: http://llvm.org/viewvc/llvm-project?rev=93305&view=rev
Log:
eliminate some uses of Mangler::makeNameProper.

Modified:
    llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp
    llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp
    llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp

Modified: llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp?rev=93305&r1=93304&r2=93305&view=diff

==============================================================================
--- llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp Wed Jan 13 01:56:59 2010
@@ -71,18 +71,19 @@
       }
 
       void Init(StringRef GVName, Mangler *Mang) {
-        // Already initialized.
-        if (!Stub.empty()) return;
+        assert(!GVName.empty());
+        if (!Stub.empty()) return; // Already initialized.
+        // Get the names for the external symbol name.
         SmallString<128> TmpStr;
-        Mang->makeNameProper(TmpStr, GVName + "$stub", Mangler::Private);
+        Mang->getNameWithPrefix(TmpStr, GVName + "$stub", Mangler::Private);
         Stub = TmpStr.str();
         TmpStr.clear();
         
-        Mang->makeNameProper(TmpStr, GVName + "$lazy_ptr", Mangler::Private);
+        Mang->getNameWithPrefix(TmpStr, GVName + "$lazy_ptr", Mangler::Private);
         LazyPtr = TmpStr.str();
         TmpStr.clear();
         
-        Mang->makeNameProper(TmpStr, GVName + "$stub$tmp", Mangler::Private);
+        Mang->getNameWithPrefix(TmpStr, GVName + "$stub$tmp", Mangler::Private);
         AnonSymbol = TmpStr.str();
       }
     };
@@ -237,7 +238,7 @@
         }
         if (MO.getType() == MachineOperand::MO_ExternalSymbol) {
           SmallString<128> MangledName;
-          Mang->makeNameProper(MangledName, MO.getSymbolName());
+          Mang->getNameWithPrefix(MangledName, MO.getSymbolName());
           FnStubInfo &FnInfo = FnStubs[MangledName.str()];
           FnInfo.Init(MO.getSymbolName(), Mang);
           O << FnInfo.Stub;

Modified: llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp?rev=93305&r1=93304&r2=93305&view=diff

==============================================================================
--- llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp (original)
+++ llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp Wed Jan 13 01:56:59 2010
@@ -1080,7 +1080,7 @@
   if (GV->isWeakForLinker()) {
     const char *Prefix = getCOFFSectionPrefixForUniqueGlobal(Kind);
     SmallString<128> Name(Prefix, Prefix+strlen(Prefix));
-    Mang->makeNameProper(Name, GV->getNameStr());
+    Mang->getNameWithPrefix(Name, GV->getName());
     return getCOFFSection(Name.str(), false, Kind);
   }
 

Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp?rev=93305&r1=93304&r2=93305&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp Wed Jan 13 01:56:59 2010
@@ -283,24 +283,32 @@
     break;
   }
   case MachineOperand::MO_ExternalSymbol: {
-    Mang->makeNameProper(TempNameStr, MO.getSymbolName());
+    const MCSymbol *SymToPrint;
     if (MO.getTargetFlags() == X86II::MO_DARWIN_STUB) {
-      TempNameStr += "$stub";
-      MCSymbol *Sym = OutContext.GetOrCreateSymbol(TempNameStr.str());
+      Mang->getNameWithPrefix(TempNameStr,
+                              StringRef(MO.getSymbolName())+"$stub");
+      const MCSymbol *Sym = OutContext.GetOrCreateSymbol(TempNameStr.str());
       const MCSymbol *&StubSym =
         MMI->getObjFileInfo<MachineModuleInfoMachO>().getFnStubEntry(Sym);
       if (StubSym == 0) {
         TempNameStr.erase(TempNameStr.end()-5, TempNameStr.end());
         StubSym = OutContext.GetOrCreateSymbol(TempNameStr.str());
       }
+      SymToPrint = StubSym;
+    } else {
+      Mang->getNameWithPrefix(TempNameStr, MO.getSymbolName());
+      SymToPrint = OutContext.GetOrCreateSymbol(TempNameStr.str());
     }
     
     // If the name begins with a dollar-sign, enclose it in parens.  We do this
     // to avoid having it look like an integer immediate to the assembler.
-    if (TempNameStr[0] == '$') 
-      O << '(' << TempNameStr << ')';
-    else
-      O << TempNameStr;
+    if (SymToPrint->getName()[0] != '$') 
+      SymToPrint->print(O, MAI);
+    else {
+      O << '(';
+      SymToPrint->print(O, MAI);
+      O << '(';
+    }
     break;
   }
   }