[llvm-commits] [llvm] r93270 - /llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp

[Chris Lattner]

On Jan 12, 2010, at 7:19 PM, Victor Hernandez wrote:

> 
> On Jan 12, 2010, at 6:55 PM, Chris Lattner wrote:
> 
>> On Jan 12, 2010, at 6:28 PM, Devang Patel wrote:
>>>> It very well could turn out to be just that.  Currently I am seeing stray function-local values in the ValueList when the global constants are getting written.  I am working on getting them to not exist until incorporateFunction time, but even then, I don't know if there will be stray values while function-local constants are being written.  
>>> 
>>> hmm.. stray values are not good, we should flag these values.
>>> 
>>>> I'll update you after some more investigation.
>>> 
>>> You may want to keep this patch in your local tree while you sort out function-local values patch.
>> 
>> Yes, this shouldn't go into mainline, please revert it Victor.
> 
> Ok, just reverted it.  It does look like I can avoid adding those stray values to the ValueEnumerator.

Thanks!