[llvm-commits] [llvm] r93149 - in /llvm/trunk: include/llvm/Analysis/DebugInfo.h include/llvm/IntrinsicInst.h lib/Analysis/DebugInfo.cpp lib/VMCore/IntrinsicInst.cpp

[Victor Hernandez]

Yes, that will go in today.

Also for today that is pending from your reviews:
> With this change, there is no difference between ConvertGlobalValIDToValue, ConvertGlobalOrMetadataValIDToValue, and ConvertValIDToValue, except for inline asm.  Can they all be merged into one function now and use the PFS pointer to distinguish the function-local vs global case?

Victor

On Jan 11, 2010, at 8:46 AM, Chris Lattner wrote:

> 
> On Jan 10, 2010, at 11:45 PM, Victor Hernandez wrote:
> 
>> Author: hernande
>> Date: Mon Jan 11 01:45:19 2010
>> New Revision: 93149
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=93149&view=rev
>> Log:
>> Respond to Chris' review:
>> Make InsertDbgValueIntrinsic() and get Offset take and recieve a uint64_t.
>> Get constness correct for getVariable() and getValue().
> 
> Nice, thanks Victor.  Don't forget the LangRef piece,
> 
> -Chris