[llvm-commits] [llvm] r92943 - in /llvm/trunk: lib/CodeGen/SelectionDAG/TargetLowering.cpp test/CodeGen/Generic/2009-04-28-i128-cmp-crash.ll

[Duncan Sands]

Hi Evan,

>> if the shift amount is too big to fit in unsigned, then I guess the shift is
>> undefined, even on arbitrary precision integers.  So how about using going back
>> to unsigned but with getLimitedValue instead of getZExtValue?
> 
> Does it actually matters though? (That is, would this actually cause codegen difference?) I'd prefer for the whole function to be consistent by using APInt.

it is a micro-optimization (avoid the cost of an APInt), not for correctness.
This optimization is probably not worth the time we've spent discussing it, so
I won't insist :)

Ciao,

Duncan.