[llvm-commits] [llvm] r92988 - in /llvm/trunk: lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp test/CodeGen/X86/2010-01-07-ISelBug.ll
Evan Cheng
evan.cheng at apple.com
Fri Jan 8 16:32:02 PST 2010
Fixed. 93031.
Evan
On Jan 7, 2010, at 6:44 PM, Dan Gohman wrote:
>
> On Jan 7, 2010, at 6:36 PM, Evan Cheng wrote:
>>
>>
>> if (N->use_empty() && N != CurDAG->getRoot().getNode()) {
>> - CurDAG->DeleteNode(N);
>> + if (N->getOpcode() != ISD::DELETED_NODE)
>> + CurDAG->DeleteNode(N);
>
> This isn't safe. A node's opcode is only set to DELETED_NODE when it
> is actually being deallocated. You can't count on it staying set because
> the node could get re-allocated for another purpose at any time.
>
> Dan
>
More information about the llvm-commits
mailing list