[llvm-commits] [llvm] r92761 - in /llvm/trunk: docs/LangRef.html include/llvm/Metadata.h lib/AsmParser/LLParser.cpp lib/Bitcode/Reader/BitcodeReader.cpp lib/VMCore/Metadata.cpp unittests/VMCore/MetadataTest.cpp

Devang Patel dpatel at apple.com
Fri Jan 8 16:30:52 PST 2010


On Jan 8, 2010, at 11:45 AM, Chris Lattner wrote:

>> +++ llvm/trunk/include/llvm/Metadata.h Tue Jan  5 14:41:31 2010
>> @@ -167,7 +167,7 @@
>> };
>>
>> // 
>> = 
>> = 
>> = 
>> ----------------------------------------------------------------------= 
>> ==//
>> -/// NamedMDNode - a tuple of other metadata.
>> +/// NamedMDNode - a tuple of MDNodes.
>> /// NamedMDNode is always named. All NamedMDNode operand has a type  
>> of metadata.
>> class NamedMDNode : public MetadataBase, public  
>> ilist_node<NamedMDNode> {
>
> This should inherit from Value, not MetadataBase.
>

( ... but it is still a metadata! )

Done.
-
Devang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100108/dd869167/attachment.html>


More information about the llvm-commits mailing list