[llvm-commits] [llvm] r92853 - in /llvm/trunk/lib/Transforms: InstCombine/InstCombineCalls.cpp Scalar/SimplifyLibCalls.cpp
Chris Lattner
clattner at apple.com
Fri Jan 8 11:04:42 PST 2010
On Jan 8, 2010, at 10:52 AM, Eric Christopher wrote:
> On Jan 8, 2010, at 10:16 AM, Chris Lattner wrote:
>
>> I still don't "get" this. The idea of objectsize is that we want
>> to propagate it to CodeGenPrepare (which happens right before
>> isel). CGP should be doing this to remove the intrinsics. Instead
>> of zapping them, instcombine should be trying to infer the size of
>> the object and replacing them with a real answer. With your
>> current implementation, I don't see how it is any better than
>> folding it to "don't know" in the front-end.
>
> No, you've got it. Right now I'm not inferring, I was just moving
> the code from where I had it in libcallsimplify to where you wanted
> it in instcombine. I should probably have put a TODO in there of
> "compute the sizes" :)
>
> Basically it's no change of behavior from when we were lowering it
> to "don't know" in the front end, but I'm going to fix that as soon
> as I can.
Ok, thanks.
-Chris
More information about the llvm-commits
mailing list