[llvm-commits] [PATCH 1/3] Fix DFS number calculation for postdominators

[Dan Gohman]

This looks good. The more code that can use the virtual root rather
than trying to work with multiple roots, the better :-).
Please add a comment saying what you said in the last two sentences there.

Dan

On Jan 6, 2010, at 3:27 PM, Tobias Grosser wrote:

> 
> The DFS number calculation for postdominators was broken. In the case of
> multiple exits that form the post dominator root nodes, do not iterate over
> all exits, but start from the virtual root node. Otherwise bbs, that are not
> post dominated by any exit but by the virtual root node, will never be assigned
> a DFS number.
> ---
> include/llvm/Analysis/Dominators.h |   48 ++++++++++++++++++-----------------
> 1 files changed, 25 insertions(+), 23 deletions(-)
> 
> <0001-Fix-DFS-number-calculation-for-postdominators.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits