[llvm-commits] [llvm] r92918 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

[Benjamin Kramer]

Author: d0k
Date: Thu Jan  7 11:27:56 2010
New Revision: 92918

URL: http://llvm.org/viewvc/llvm-project?rev=92918&view=rev
Log:
Use pop_back_val instead of back()+pop_back.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp?rev=92918&r1=92917&r2=92918&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp Thu Jan  7 11:27:56 2010
@@ -456,8 +456,7 @@
 
   TargetLowering::TargetLoweringOpt TLO(*CurDAG, true);
   while (!Worklist.empty()) {
-    SDNode *N = Worklist.back();
-    Worklist.pop_back();
+    SDNode *N = Worklist.pop_back_val();
 
     if (N->use_empty() && N != CurDAG->getRoot().getNode()) {
       CurDAG->DeleteNode(N);
@@ -467,7 +466,6 @@
     // Run ShrinkDemandedOp on scalar binary operations.
     if (N->getNumValues() == 1 &&
         N->getValueType(0).isSimple() && N->getValueType(0).isInteger()) {
-      DebugLoc dl = N->getDebugLoc();
       unsigned BitWidth = N->getValueType(0).getScalarType().getSizeInBits();
       APInt Demanded = APInt::getAllOnesValue(BitWidth);
       APInt KnownZero, KnownOne;
@@ -520,9 +518,8 @@
   APInt KnownZero;
   APInt KnownOne;
 
-  while (!Worklist.empty()) {
-    SDNode *N = Worklist.back();
-    Worklist.pop_back();
+  do {
+    SDNode *N = Worklist.pop_back_val();
 
     // If we've already seen this node, ignore it.
     if (!VisitedNodes.insert(N))
@@ -562,7 +559,7 @@
       LOI.KnownOne = KnownOne;
       LOI.KnownZero = KnownZero;
     }
-  }
+  } while (!Worklist.empty());
 }
 
 void SelectionDAGISel::CodeGenAndEmitDAG() {