[llvm-commits] [llvm] r92296 - /llvm/trunk/lib/AsmParser/LLParser.cpp
Chris Lattner
sabre at nondot.org
Tue Dec 29 21:04:46 PST 2009
Author: lattner
Date: Tue Dec 29 23:04:46 2009
New Revision: 92296
URL: http://llvm.org/viewvc/llvm-project?rev=92296&view=rev
Log:
remove two bogus calls that accepted metadata in the middle of insert/extract value
*constant exprs*.
Modified:
llvm/trunk/lib/AsmParser/LLParser.cpp
Modified: llvm/trunk/lib/AsmParser/LLParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/AsmParser/LLParser.cpp?rev=92296&r1=92295&r2=92296&view=diff
==============================================================================
--- llvm/trunk/lib/AsmParser/LLParser.cpp (original)
+++ llvm/trunk/lib/AsmParser/LLParser.cpp Tue Dec 29 23:04:46 2009
@@ -2116,9 +2116,6 @@
ParseIndexList(Indices) ||
ParseToken(lltok::rparen, "expected ')' in extractvalue constantexpr"))
return true;
- // FIXME: THIS ISN'T RIGHT? WHERE IS THE COMMA?
- if (Lex.getKind() == lltok::MetadataVar)
- if (ParseOptionalCustomMetadata()) return true;
if (!isa<StructType>(Val->getType()) && !isa<ArrayType>(Val->getType()))
return Error(ID.Loc, "extractvalue operand must be array or struct");
@@ -2141,8 +2138,6 @@
ParseIndexList(Indices) ||
ParseToken(lltok::rparen, "expected ')' in insertvalue constantexpr"))
return true;
- if (Lex.getKind() == lltok::MetadataVar)
- if (ParseOptionalCustomMetadata()) return true;
if (!isa<StructType>(Val0->getType()) && !isa<ArrayType>(Val0->getType()))
return Error(ID.Loc, "extractvalue operand must be array or struct");
if (!ExtractValueInst::getIndexedType(Val0->getType(), Indices.begin(),
More information about the llvm-commits
mailing list