[llvm-commits] [llvm] r92223 - /llvm/trunk/lib/VMCore/Metadata.cpp

[Chris Lattner]

Author: lattner
Date: Mon Dec 28 13:49:00 2009
New Revision: 92223

URL: http://llvm.org/viewvc/llvm-project?rev=92223&view=rev
Log:
tidy up and delete a dead smallvector.

Modified:
    llvm/trunk/lib/VMCore/Metadata.cpp

Modified: llvm/trunk/lib/VMCore/Metadata.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/Metadata.cpp?rev=92223&r1=92222&r2=92223&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/Metadata.cpp (original)
+++ llvm/trunk/lib/VMCore/Metadata.cpp Mon Dec 28 13:49:00 2009
@@ -23,10 +23,6 @@
 using namespace llvm;
 
 //===----------------------------------------------------------------------===//
-// MetadataBase implementation.
-//
-
-//===----------------------------------------------------------------------===//
 // MDString implementation.
 //
 
@@ -130,6 +126,8 @@
 void MDNode::Profile(FoldingSetNodeID &ID) const {
   for (unsigned i = 0, e = getNumElements(); i != e; ++i)
     ID.AddPointer(getElement(i));
+  // HASH TABLE COLLISIONS?
+  // DO NOT REINSERT AFTER AN OPERAND DROPS TO NULL!
 }
 
 
@@ -433,10 +431,8 @@
   MDStoreTy::iterator I = MetadataStore.find(In1);
   assert(I != MetadataStore.end() && "Invalid custom metadata info!");
 
-  // FIXME : Give all metadata handlers a chance to adjust.
-
+  // FIXME: Give all metadata handlers a chance to adjust.
   MDMapTy &In1Info = I->second;
-  MDMapTy In2Info;
   for (MDMapTy::iterator I = In1Info.begin(), E = In1Info.end(); I != E; ++I)
     addMD(I->first, I->second, In2);
 }
@@ -449,15 +445,14 @@
   if (!I1 || !I2)
     return;
 
-  // FIXME : Give custom handlers a chance to override this.
+  // FIXME: Give custom handlers a chance to override this.
   ValueIsCloned(I1, I2);
 }
 
 //===----------------------------------------------------------------------===//
 // MetadataContext implementation.
 //
-MetadataContext::MetadataContext() 
-  : pImpl(new MetadataContextImpl()) { }
+MetadataContext::MetadataContext() : pImpl(new MetadataContextImpl()) { }
 MetadataContext::~MetadataContext() { delete pImpl; }
 
 /// isValidName - Return true if Name is a valid custom metadata handler name.