[llvm-commits] [llvm] r92046 - /llvm/trunk/lib/Analysis/PHITransAddr.cpp

[David Greene]

On Wednesday 23 December 2009 16:27, Chris Lattner wrote:
> On Dec 23, 2009, at 1:06 PM, David Greene wrote:
> > Author: greened
> > Date: Wed Dec 23 15:06:14 2009
> > New Revision: 92046
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=92046&view=rev
> > Log:
> >
> > Convert debug messages to use dbgs().  Generally this means
> > s/errs/dbgs/g except for certain special cases.
>
> The change to dump() is fine, the others are not.

I'll change it back but this has similar issues as other files.
Do we want to see these messages out-of-line with respect to debug
messages?

I didn't make these changes willy-nilly.  I thought about it and
concluded it would be better to keep messages in-order.  If we
decide that's not important, that's probably fine (there may be
some special cases) but we should be aware of what we're deciding.

Remember, dbgs() == errs() except for a very exceptional case.

                             -Dave