[llvm-commits] [llvm] r92006 - /llvm/trunk/include/llvm/Analysis/LoopInfo.h

[Chris Lattner]

On Dec 23, 2009, at 10:39 AM, David Greene wrote:

> On Wednesday 23 December 2009 12:20, Chris Lattner wrote:
>> On Dec 23, 2009, at 10:14 AM, David Greene wrote:
>>> On Wednesday 23 December 2009 11:52, Chris Lattner wrote:
>>>> Please pull the dump() implementation out of line.
>>>
>>> How?  LoopBase is a template.  I could go through various  
>>> contortions
>>> to produce a .ipp file with template implementation code and then
>>> #include that everywhere LoopInfo.h is included, but is it worth it?
>>
>> Ugh, that's unfortunate.  Lets just remove dump() from loopinfo, I
>> don't think anyone uses it in practice anyway.
>
> LoopStrengthReduce.cpp.

Change it to use print(dbgs()).


> I don't want to go back to errs() for cases like this because it  
> will present
> inconsistent debug output.  And I don't want to remove dumps from  
> clients
> that use them for debugging purposes.

Please just remove it and change clients to use print(dbgs());

-Chris