[llvm-commits] [llvm] r92006 - /llvm/trunk/include/llvm/Analysis/LoopInfo.h

[Chris Lattner]

On Dec 23, 2009, at 10:14 AM, David Greene wrote:

> On Wednesday 23 December 2009 11:52, Chris Lattner wrote:
>> Please pull the dump() implementation out of line.
>
> How?  LoopBase is a template.  I could go through various contortions
> to produce a .ipp file with template implementation code and then
> #include that everywhere LoopInfo.h is included, but is it worth it?

Ugh, that's unfortunate.  Lets just remove dump() from loopinfo, I  
don't think anyone uses it in practice anyway.

> Especially given that other headers already include Debug.h?  See
> ProfileInfo.h.

I didn't know about that one either, it should be fixed or at least  
not propagated.  #includ'ing Debug.h into LLVM headers is particularly  
bad because LLVM headers are often included into random other code  
(clients of llvm) and the DEBUG macro conflicts with their random view  
of what DEBUG should be.

-Chris