[llvm-commits] [llvm] r91392 - in /llvm/trunk: include/llvm/CodeGen/SelectionDAG.h lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp lib/CodeGen/SelectionDAG/SelectionDAG.cpp lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

[Chris Lattner]

On Dec 17, 2009, at 3:37 PM, Bill Wendling wrote:

>>
>> I don't think that this is the right layer to do this at.  The  
>> "Ordering" of nodes is only defined at Builder time, not in general  
>> when instructions are randomly created by other parts of SD  
>> machinery.  The various calls to Ordering->add should only happen  
>> from the builder.
>>
>> OTOH, calls to *remove* a node from the ordering *should* happen  
>> from the common SD code when the node is about to be deleted.
>>
> Hmm...I was hoping to make this a very low-level thing so that the  
> higher levels wouldn't even know about it. There may be a problem  
> because node creation & modification doesn't stop at the builder,  
> but could happen when lowering to target nodes. I'll look into it,  
> though.
>

Yeah, I see where you're coming from.  My hope is that only the  
builder, the target-indep parts of isel, and the scheduler will have  
to know about this stuff.

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20091222/52701f66/attachment.html>